chore(hybrid-cloud): transactions for metrics#45592
Conversation
github-actions
bot
added
the
Scope: Backend
| ) -> Callable[..., Any]: | ||
| def wrapper(*args: Any, **kwds: Any) -> Any: | ||
| with sentry_sdk.start_transaction( | ||
| op=f"hybrid_cloud.services.{service_class_name}", name="execute" |
There was a problem hiding this comment.
@markstory Should the op be execute, and the name be what the op is here?
There was a problem hiding this comment.
| op=f"hybrid_cloud.services.{service_class_name}", name="execute" | |
| op=f"execute", name="hybrid_cloud.services.{service_class_name}.execute" |
Flipping the names here might be better as name is used as the transaction name across the UI and is how you would search for this transaction.
There was a problem hiding this comment.
This would be more helpful it it included the method name too, right?
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Should we have client side sampling for these transactions? Previously we were getting very high volume on the execute transaction, would we still get useful signal from a lower volume? Or is full volume the signal we want?
| ) -> Callable[..., Any]: | ||
| def wrapper(*args: Any, **kwds: Any) -> Any: | ||
| with sentry_sdk.start_transaction( | ||
| op=f"hybrid_cloud.services.{service_class_name}", name="execute" |
There was a problem hiding this comment.
| op=f"hybrid_cloud.services.{service_class_name}", name="execute" | |
| op=f"execute", name="hybrid_cloud.services.{service_class_name}.execute" |
Flipping the names here might be better as name is used as the transaction name across the UI and is how you would search for this transaction.
Some specific services have high volume, while others do not (they may have very low volume, but are still important). I could try a sampling rate and see what happens. |
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
📿 hopefully this goes better this time around.
|
PR reverted: 617e253 |
This reverts commit dfb137d. Co-authored-by: corps <593850+corps@users.noreply.github.com>
4 participants
No description provided.